-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane: tailsitter rate limit second half of VTOL transition. #19286
Conversation
I have found a wacky interaction with the position controller in some cases. |
I fixed the odd pitch stuff, quadplane was force feeding the position controller velocity targets bypassing the input shaping and velocity limits. The last commit fixes that and uses the |
b4d6c85
to
f0ef1cf
Compare
rebased |
Tested on the CAT and H wing in realflight both inverted and normal transitions and QRTL position controller. |
f0ef1cf
to
7b6fa6a
Compare
This now applys a pitch up rate limit to the second half of the transition into VTOL flight. Rather than just pulling up to
Q_TAILSIT_ANG_VT
and dumping to the VTOL controller, the pitch up rate is now limited as the sameQ_TAILSIT_RAT_VT
that the first half of the transition is done at. Once the desired pitch angle is larger than the pitch up limit the limit is removed.The limit it applied in all modes, except QACRO.
In addition we now no longer run the Z controller in tailsitter VTOL transition or if the throttle state is not unlimited. We always do a full pitch relax on transition entry (if not in Qassist) and pass the current time to
tailsitter.in_vtol_transition
that already have the time available in the function, this should reduce the chances of a race condition.The result of these changes are a much smoother transition from the FW pull up to the VTOL flight. You can still see the step as we swap from the FW to VTOL controller, but it is much smoother. This also enables lower
Q_TAILSIT_ANG_VT
values without a very aggressive pitch up.